enable all errorprone checks by default and resolve their nit warnings #3527
ben-manesAnnotations
30 warnings
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/ConcurrentTestHarness.java#L87
[UnnecessaryFinal] Since Java 8, it's been unnecessary to make local variables and parameters `final` for use in lambdas or anonymous classes. Marking them as `final` is weakly discouraged, as it adds a fair amount of noise for minimal benefit.
|
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/ConcurrentTestHarness.java#L87
[Var] Unnecessary 'final' modifier.
|
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/Threads.java#L73
[MemberName] Methods and non-static variables should be named in lowerCamelCase, with acronyms treated as words (https://google.github.io/styleguide/javaguide.html#s5.3-camel-case), but timeNS is not
|
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/LoggingEvents.java#L132
[Var] Non-constant variable missing @var annotation
|
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L83
[MemberName] Methods and non-static variables should be named in lowerCamelCase, but get_function is not; did you mean 'getFunction'?
|
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L112
[MemberName] Methods and non-static variables should be named in lowerCamelCase, but get_asMap is not; did you mean 'getAsMap'?
|
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L117
[MemberName] Methods and non-static variables should be named in lowerCamelCase, but put_asMap is not; did you mean 'putAsMap'?
|
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L115
[MethodCanBeStatic] A private method that does not reference the enclosing instance can be static
|
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L138
[Var] Non-constant variable missing @var annotation
|
|
benchmarks (GraalVM):
caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L165
[Var] Non-constant variable missing @var annotation
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/ConcurrentTestHarness.java#L87
[UnnecessaryFinal] Since Java 8, it's been unnecessary to make local variables and parameters `final` for use in lambdas or anonymous classes. Marking them as `final` is weakly discouraged, as it adds a fair amount of noise for minimal benefit.
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/ConcurrentTestHarness.java#L87
[Var] Unnecessary 'final' modifier.
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/Threads.java#L73
[MemberName] Methods and non-static variables should be named in lowerCamelCase, with acronyms treated as words (https://google.github.io/styleguide/javaguide.html#s5.3-camel-case), but timeNS is not
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/LoggingEvents.java#L132
[Var] Non-constant variable missing @var annotation
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L83
[MemberName] Methods and non-static variables should be named in lowerCamelCase, but get_function is not; did you mean 'getFunction'?
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L112
[MemberName] Methods and non-static variables should be named in lowerCamelCase, but get_asMap is not; did you mean 'getAsMap'?
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L117
[MemberName] Methods and non-static variables should be named in lowerCamelCase, but put_asMap is not; did you mean 'putAsMap'?
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L115
[MethodCanBeStatic] A private method that does not reference the enclosing instance can be static
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L138
[Var] Non-constant variable missing @var annotation
|
|
benchmarks (21):
caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L165
[Var] Non-constant variable missing @var annotation
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/ConcurrentTestHarness.java#L87
[UnnecessaryFinal] Since Java 8, it's been unnecessary to make local variables and parameters `final` for use in lambdas or anonymous classes. Marking them as `final` is weakly discouraged, as it adds a fair amount of noise for minimal benefit.
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/ConcurrentTestHarness.java#L87
[Var] Unnecessary 'final' modifier.
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/Threads.java#L73
[MemberName] Methods and non-static variables should be named in lowerCamelCase, with acronyms treated as words (https://google.github.io/styleguide/javaguide.html#s5.3-camel-case), but timeNS is not
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/testing/LoggingEvents.java#L132
[Var] Non-constant variable missing @var annotation
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L83
[MemberName] Methods and non-static variables should be named in lowerCamelCase, but get_function is not; did you mean 'getFunction'?
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L112
[MemberName] Methods and non-static variables should be named in lowerCamelCase, but get_asMap is not; did you mean 'getAsMap'?
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L117
[MemberName] Methods and non-static variables should be named in lowerCamelCase, but put_asMap is not; did you mean 'putAsMap'?
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L115
[MethodCanBeStatic] A private method that does not reference the enclosing instance can be static
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L138
[Var] Non-constant variable missing @var annotation
|
|
benchmarks (11):
caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L165
[Var] Non-constant variable missing @var annotation
|