Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.github.valfirst:slf4j-test from 2.9.0 to 3.0.0 #1067

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 12, 2023

Bumps com.github.valfirst:slf4j-test from 2.9.0 to 3.0.0.

Release notes

Sourced from com.github.valfirst:slf4j-test's releases.

v3.0.0

slf4j-test-3.0.0 (2023-07-11)

Full Changelog

Breaking changes

  • #380 via #383 - Switch from Lidalia Level to SLF4J Level (by @​karstenspang)

    • uk.org.lidalia.slf4jext.Level is replaced with org.slf4j.event.Level

      The org.slf4j.event.Level class has been present in SLF4J since version 1.7.15 from 2016. There is little reason for a client to use a version older than that.

      Changing the import statement from one package to the other handles most of the changes. But some differences between the two Level classes remain.

      Ordinal Values

      In uk.org.lidalia.slf4jext.Level, ERROR has the lowest ordinal value, and TRACE has the highest. In org.slf4j.event.Level, it is the other way round. When comparing levels using Enum.compareTo, the equality sign will have to be reversed. In SLF4J Test, this is used to decide whether to print the log message.

      OFF Level

      org.slf4j.event.Level has no OFF level. This means that another way must be used to specify that printing is off. null is the only other value you can pass as an enum. The print level logic is changed to use null as "off".

      enableableLevels

      uk.org.lidalia.slf4jext.Level has the static method enableableLevels that returns the set of enum values corresponding to log levels that can be enabled. Since all values represent enableable levels in org.slf4j.event.Level, EnumSet.allOf(Level.class) provides the equivalent funtionality.

    • Dependency uk.org.lidalia:lidalia-slf4j-ext is dropped

  • #380 via #384 - Remove Guava as dependency (by @​karstenspang)

    • Guava Collections are replaced with Java Collections

      Parameter and return types are changed to be simply List, Map, or Set, instead of the specific ones from Guava. The client can still pass the Guava ones as parameters if needed. In case the client assign a returned value to a specific type, code changes are needed.

      Returned vales are wrapped using java.util.Collections.unmodifiableList/Map/Set after copying.

      Internal values are implemented using ArrayList, HashMap, or HashSet wrapped to be made unmodifiable. As a special case, enabled log level sets are to be represented as EnumSet<Level>.

    • Dependency com.google.guava:guava is dropped

  • #312, #380 via #326 - Use java.time's Instant rather than joda-time (by @​josephw)

    • org.joda.time.Instant is replaced with java.time.Instant
    • Dependency joda-time:joda-time is dropped
  • #390 via #394 - Avoid substitution of null values (by @​karstenspang)

    null-s were replaced by other values:

    • When a LoggingEvent was constructed with arguments, null-s were replaced with Option.empty(). If logging events were just compared, such replacement had no impact. So restoration of null-s is considered as an internal change here.
    • If null value was inserted in the MDC, it was replaced with the string "null". If MDC functionality were tested, such replacement could be annoying. In particular, the assertion failure message showed null in both the expected and the actual value. Now such substitution is eliminated, null value is always used.

... (truncated)

Commits
  • c027968 [maven-release-plugin] prepare release slf4j-test-3.0.0
  • 0e3ce70 Prepare 3.0.0 release
  • 05e99bc Fix spotless violations in pom.xml
  • 8ba470e Fix generation of Surefire and JaCoCo reports
  • 870095c Add missing parts of fluent logging API (#412)
  • 160fccf Drop static binders (#411)
  • 5d2a1c6 Remove usage of deprecated PMD plugin parameter
  • 43e9ce0 Clean up the code
  • 3f1ca1d Fix typos
  • cfa06c3 Add ability to configure cleanup stage (#410)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.github.valfirst:slf4j-test](https://github.com/valfirst/slf4j-test) from 2.9.0 to 3.0.0.
- [Release notes](https://github.com/valfirst/slf4j-test/releases)
- [Commits](valfirst/slf4j-test@slf4j-test-2.9.0...slf4j-test-3.0.0)

---
updated-dependencies:
- dependency-name: com.github.valfirst:slf4j-test
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 12, 2023
@ben-manes ben-manes closed this Jul 12, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 12, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/com.github.valfirst-slf4j-test-3.0.0 branch July 12, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant