Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunchtime stab at adding temporary halts on payments #6

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

the-frey
Copy link

@the-frey the-frey commented Jan 4, 2022

Had a spare half hour. Initially went the route of removing payments but that approach would result in dodgy behaviour (I think!) when the following scenario occurs:

  • Halt a payment because of non delivery before payment date
  • Resolve dispute before payment date
  • Wish to reinstate payment before payment date

Therefore the non-destructive approach with filtering seemed to make more sense.

Hence putting it in a separate piece of state.

TODO:

  • Needs some unit tests
  • Versions are out-of-date so need to bump & fix

Relates to #5

@vernonjohnson
Copy link

I like this approach. Only question is whether or not the halting should be a bit more granular. You could halt individual payments, rather than all payments to a recipient. And if you wanted to halt all payments to a specific recipient, you can pass in multiple payment ids to do so, which gives you feature parity with this draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants