Skip to content

Commit

Permalink
typo
Browse files Browse the repository at this point in the history
  • Loading branch information
@wassimmazouz
wassimmazouz committed Jul 3, 2024
1 parent 07d07e4 commit a3890e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion solvers/snapml.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class Solver(BaseSolver):
name = "snapml"

install_cmd = "conda"
requirements = ["pip:snapml","numpy<2"]
requirements = ["pip:snapml", "pip:numpy<2"]

This comment has been minimized.

Sign in to view

Copy link
@mathurinm

mathurinm Jul 3, 2024

Contributor

numpy should still be installable via conda, right ?
did you find somewhere that snapml does not support numpy 2? I couldn't

This comment has been minimized.

Sign in to view

Copy link
@wassimmazouz

wassimmazouz Jul 3, 2024

Author Contributor

From this error message, I'm guessing it compiles with 1.x but the benchopt CI installs numpy 2.0. However I didn't find any documentation which confirms this issues with numpy 2

parameters = {"gpu": [False, True]}
references = [
Expand Down

0 comments on commit a3890e4

Please sign in to comment.