Allow Default values for entities/allow still creating the row element #191 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…benct#191 Added the possibility to show a default value in the UI if the entity does not exist or should not be shown updated the README.MD to describe the default parameter
ildar170975
reviewed
May 30, 2023
| @@ -80,6 +80,7 @@ attribute value instead of the state value. `icon` lets you display an icon inst | |||
| | toggle | bool | `false` | Display a toggle if supported by domain | | |||
| | icon | string/bool | `false` | Display default or custom icon instead of state or attribute value | | |||
| | state_color | bool | `false` | Enable colored icon when entity is active | | |||
| | default | string | | Display this value if the entity does not exist or should not be shown | | |||
There was a problem hiding this comment.
Currently this description is very unclear.
Please elaborate:
- "Does not exist": means "the entity does not exist"?
- "Or should not be shown": if the entity is a valid one (
sun.sun) and thedefaultoption is specified - what we will see then? Seems that this description should be changed.
There was a problem hiding this comment.
- I am not sure what you mean with the first the question, as this is the exact description I have added. The description says "if the entity does not exist".
- "or should not be shown". There is a "hide_if" option. If the entity should not be shown because of this "hide_if" value/criteria matches, it would fall back to the default value.
There was a problem hiding this comment.
- There is a "hide_if" option. If the entity should not be shown because of this "hide_if" value/criteria matches, it would fall back to the default value.
I suggest to explicitly mention the hide_if option in this description.
There was a problem hiding this comment.
Also, this is not only about hide_if option - seems that it works with hide_unavailable too
|
Found a bug: #302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to show a default value in the UI if the entity does not exist or should not be shown
updated the README.MD to describe the default parameter
See #191 for the full description of the Problem