Version 0.4-alpha #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: redesign barcode
pull github actions to dev branch
./aamva_standard/barcode.py:3:1: E731 do not assign a lambda expression, use a def
./aamva_standard/test_barcode.py:164:1: W391 blank line at end of file
./aamva_standard/issuing_authority.py:86:80: E501 line too long (80 > 79 characters)
./aamva_standard/issuing_authority.py:13:80: E501 line too long (80 > 79 characters)
./aamva_standard/issuing_authority.py:92:80: E501 line too long (107 > 79 characters) also renamed the variable to issuing_authority as we should get a single IssuingAuthority object.
./aamva_standard/test_issuing_authority.py:8:80: E501 line too long (90 > 79 characters) ./aamva_standard/test_issuing_authority.py:9:80: E501 line too long (86 > 79 characters)
./aamva_standard/test_issuing_authority.py:23:80: E501 line too long (80 > 79 characters) ./aamva_standard/test_issuing_authority.py:24:80: E501 line too long (91 > 79 characters) ./aamva_standard/test_issuing_authority.py:25:80: E501 line too long (91 > 79 characters)
Fix flake8 E501 line too long errors batch 1
… and coverage reporting
TypeError: unsupported operand type(s) for |: 'type' and 'type'
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of work over the past few days. I think I can confidently say we can decode the barcode. Now to decode the data returned by the subfiles. Plans for decoding the subfiles based on the AAMVA version is in the works. (I should make that an Issue or project or something)
I am still gathering older versions of the AAMVA standard but it is proving difficult. Some basic Googling allowed me to find versions 1, 9, and 10. The AAMVA website only displays the current version 10 and they don't seem to have an archive of older version. (which is problematic when you come across a card from an older standard and cannot fully read it) I did come across a site that has some historical data about the standard before version 10 but I cannot confirm it's full validity and will use this information only if my continued search comes up empty.
Happy New Years everyone! More great coding to come in 2024