Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature uplift puppet 8 #2

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Feature uplift puppet 8 #2

merged 8 commits into from
Oct 17, 2024

Conversation

benjamin-robertson
Copy link
Owner

  • Added unit tests
  • Improved handling of office_macro_run time fact to prevent failures with strict mode
  • Removed use of legacy facts.

Closes #1

@benjamin-robertson benjamin-robertson added bug Something isn't working enhancement New feature or request labels Oct 16, 2024
@benjamin-robertson benjamin-robertson self-assigned this Oct 16, 2024
@jortencio jortencio self-requested a review October 17, 2024 00:10
jortencio
jortencio approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@jortencio jortencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjamin-robertson benjamin-robertson merged commit a7cf9a1 into main Oct 17, 2024
8 checks passed
@benjamin-robertson benjamin-robertson deleted the feature_uplift_puppet_8 branch October 17, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jortencio jortencio jortencio approved these changes

Assignees

@benjamin-robertson benjamin-robertson

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm support for PE 2023.8.0 and later OS
2 participants
@benjamin-robertson @jortencio