Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cache instance/class user-configurable via options.cache #615

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

phryneas
Copy link
Contributor

@phryneas phryneas commented Nov 10, 2023

Here's the promised PR :)

src/index.ts Outdated Show resolved Hide resolved
Copy link
Owner

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've published these changes as optimism@0.18.0-pre.0 for you to test @phryneas, but I have one question I want to clear with you (below) before we publish 0.18.0.

src/index.ts Show resolved Hide resolved
@benjamn benjamn changed the title make the Cache class used configurable Make the Cache instance/class user-configurable Nov 28, 2023
@benjamn benjamn changed the title Make the Cache instance/class user-configurable Make Cache instance/class user-configurable via options.cache Nov 28, 2023
src/index.ts Outdated Show resolved Hide resolved
@benjamn benjamn merged commit 56001fe into benjamn:main Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants