Fix path with space in command for Aquamacs #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
requested changes
Nov 7, 2017
| @@ -46,7 +46,9 @@ | |||
| ;;; variables | |||
|
|
|||
| (defvar vr--command-python-default | |||
| (format "python %s" (expand-file-name "regexp.py" (file-name-directory load-file-name)))) | |||
| (format "python %s" | |||
| (shell-quote-argument (expand-file-name "regexp.py" | |||
There was a problem hiding this comment.
This is not the right place to put shell-quote-argument. You should rather call it when the process is called:
and
(like the other arguments that are quoted).
Tip: you can git amend your commit and force push it to the same branch to update an existing pull request. This way, you don't have to open a new PR for every iteration.
Please also drop "for Aquaemacs" from the commit title, as this fix is not about Aquaemacs. Thanks.
There was a problem hiding this comment.
No, those are the wrong places. shell-quote-argument needs to be done before vr--get-command (and vr/command-python) is constructed otherwise you get something like:
(shell-quote-argument (vr--get-command))
"python\\ /Users/nega/Library/Preferences/Aquamacs\\ Emacs/Packages/elpa/visual-regexp-steroids-20170222.253/regexp.py"
which is obviously incorrect.
benma
reviewed
Apr 6, 2018
| @@ -297,7 +297,9 @@ and the message line." | |||
| (format "%s matches --regexp %s %s %s" | |||
| (vr--get-command) | |||
| (shell-quote-argument regexp-string) | |||
| (when feedback-limit (format "--feedback-limit %s" feedback-limit)) | |||
| (if feedback-limit | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
shell-quote-argumentinstead.