fix: wrong configuration for the eth connection pool. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a specific error for missing RPC URL * fix key prefix in config.toml of the example listener
calbera
reviewed
Aug 27, 2024
calbera
reviewed
Aug 27, 2024
|
@Hartick can run |
hunter-bera
reviewed
Aug 27, 2024
* make WS client an optional one * add tests for connection_pool.go * fix lint errors
calbera
reviewed
Aug 27, 2024
calbera
reviewed
Aug 27, 2024
calbera
reviewed
Aug 27, 2024
calbera
reviewed
Aug 27, 2024
* rename function getClient in getClientFrom * move mutex usage to user-facing functions
|
@Hartick Would be good to add the nil check when |
* Add a checkEnv function used to skip the test if the env vars are not set. * Remove unneeded nil checks for HTTP clients cache * Check if the WS Url cache is null before adding WS clients to the cache.
calbera
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The example listener application doesn't start due to a
must provide a positive sizeerror.Why it doesn't work?
The
must provide a positive sizeerror is raised by thegithub.com/hashicorp/golang-lru/v2package which is used byclient/eth/connection_pool.gowhile creating the LRU caches.The LRU cache requires a number of client URLs greater than 0, but no one was passed because of a misconfiguration in the TOML file:
Config.ConnectionPoolis not under theAppsub-struct.Solution
Appprefix has been removed fromexamples/listener/config.tomlConfigstruct in theNewConnectionPoolImplfunction.