chore: Add Comet mempool and eth txpool metrics

[po-bera]

Summary by CodeRabbit

• New Features
  • Enhanced transaction pool telemetry with new metrics for better monitoring and visibility into transaction handling.
• Improvements
  • Updated transaction submission interface to include statistics for pending and queued transactions.
• Bug Fixes
  • Improved the reliability of transaction broadcast retries with additional telemetry tracking.

[coderabbitai]

Walkthrough

The Cosmos codebase has been updated to enhance transaction telemetry within the mempool. This includes tracking metrics for CometBFT transactions, conditions for transaction ejection, and transaction pool statistics. These changes will provide better insight into the transaction lifecycle, helping developers and network maintainers to monitor and optimize the network's performance.

Changes

File Path	Change Summary
.../txpool/ante.go	Added telemetry increments for CometBFT mempool transactions and ejection conditions.
.../txpool/handler.go	Extended TxSubProvider with Stats() method; updated telemetry metrics for transaction statistics and broadcast retries.
.../txpool/mempool.go	Included telemetry functions for setting gauges and incrementing counters for mempool metrics.
.../txpool/mocks/tx_sub_provider.go	Implemented new Stats method returning two integers.
.../txpool/telemetry.go	Introduced new metric keys for mempool and broadcast transaction telemetry.

Poem

In the cosmos, where transactions fly,
A rabbit watches with a keen eye.
Metrics tallied with every hop,
Ensuring the mempool does not flop. 🌌🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 25fbe13 and e62ede8.

Files selected for processing (5)

• cosmos/runtime/txpool/ante.go (3 hunks)
• cosmos/runtime/txpool/handler.go (3 hunks)
• cosmos/runtime/txpool/mempool.go (3 hunks)
• cosmos/runtime/txpool/mocks/tx_sub_provider.go (1 hunks)
• cosmos/runtime/txpool/telemetry.go (1 hunks)

Additional comments: 9

cosmos/runtime/txpool/telemetry.go (1)

• 25-45: The addition of new metric keys in telemetry.go is consistent with the PR's objective to enhance telemetry capabilities. The naming convention for the keys is consistent and follows the prefix pattern established for the CometBFT metrics. No issues found.

cosmos/runtime/txpool/mocks/tx_sub_provider.go (1)

• 45-47: The Stats method in mocks/tx_sub_provider.go has been correctly added to align with the updated TxSubProvider interface. It returns two integers, presumably for pending and queued transactions, and is initialized to return zeros, which is appropriate for a mock implementation.

cosmos/runtime/txpool/ante.go (2)

• 40-48: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [43-58]

The AnteHandle method in ante.go has been updated to include telemetry increments for transactions from the CometBFT mempool. This aligns with the PR's objective to track transaction conditions and outcomes. The telemetry increments are placed correctly within the conditional checks for transaction ejection.

• 81-92: The shouldEjectFromCometMempool method has been updated with telemetry increments for different ejection criteria. The increments are correctly placed after each condition check, which will provide detailed insights into why transactions are being ejected.

cosmos/runtime/txpool/mempool.go (2)

• 111-114: The Insert method in mempool.go has been updated to set gauges for pending and queued transactions using the Stats method from the TxPool interface. This is consistent with the PR's objective to provide real-time monitoring of the transaction pool's state.
• 133-139: The Insert method also sets a gauge for the mempool size and increments a counter for known transactions. These changes are consistent with the PR's objectives and are correctly placed within the method's logic flow.

cosmos/runtime/txpool/handler.go (3)

• 55-55: The Stats method has been added to the TxSubProvider interface in handler.go. This change is necessary for the mainLoop and failedLoop methods to retrieve transaction statistics and update telemetry metrics.
• 156-159: In the mainLoop method, the Stats method is called to retrieve transaction statistics, and telemetry metrics are updated accordingly. This is consistent with the PR's objectives to enhance telemetry capabilities.
• 176-176: The failedLoop method correctly increments a telemetry counter for broadcast retries, which aligns with the PR's objective to provide insights into the reliability of the transaction broadcasting process.