This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
Update Bank.sol #1510
Open
Update Bank.sol #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several things that can be optimized in this code. Firstly, the use of `string` type parameters can increase gas consumption. Therefore, lower gas-consuming types such as `bytes32` or `uint256` can be used as much as possible. Secondly, `mapping` or `array` structures can be used instead of `for` loops, which can reduce gas consumption. Thirdly, `view` functions can be preferred because they have lower gas consumption. Fourthly, `public` functions can be used instead of `external` functions. `external` functions consume more gas because they make data copying when they are called. Finally, correctly ordering the parameters of functions can reduce gas consumption. In particular, placing small parameters first can reduce gas consumption. However, if there is no specific performance issue in this code, any optimization may be unnecessary. Signed-off-by: Ahmet KILIÇ <imdahmetkilic@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several things that can be optimized in this code. Firstly, the use of
stringtype parameters can increase gas consumption. Therefore, lower gas-consuming types such asbytes32oruint256can be used as much as possible.Secondly,
mappingorarraystructures can be used instead offorloops, which can reduce gas consumption.Thirdly,
viewfunctions can be preferred because they have lower gas consumption.Fourthly,
publicfunctions can be used instead ofexternalfunctions.externalfunctions consume more gas because they make data copying when they are called.Finally, correctly ordering the parameters of functions can reduce gas consumption. In particular, placing small parameters first can reduce gas consumption.
However, if there is no specific performance issue in this code, any optimization may be unnecessary.