Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

feat(tx): Implement CustomGetSigners #924

Merged
merged 24 commits into from
Jul 28, 2023
Merged

feat(tx): Implement CustomGetSigners #924

merged 24 commits into from
Jul 28, 2023

Conversation

itsdevbear
Copy link
Member

part of bech32 nuking

@itsdevbear itsdevbear marked this pull request as draft July 28, 2023 12:33
@itsdevbear
Copy link
Member Author

itsdevbear commented Jul 28, 2023

@ocnc this should solve the infamous "ens" issue we had

@itsdevbear itsdevbear requested review from calbera and ocnc July 28, 2023 13:13
@itsdevbear itsdevbear marked this pull request as ready for review July 28, 2023 13:13
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #924 (4b9eb8b) into main (8aae2e7) will decrease coverage by 0.11%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 4b9eb8b differs from pull request most recent head cd4b7d4. Consider uploading reports for the commit cd4b7d4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   59.69%   59.58%   -0.11%     
==========================================
  Files         105      105              
  Lines        4441     4449       +8     
==========================================
  Hits         2651     2651              
- Misses       1676     1684       +8     
  Partials      114      114              
Files Changed Coverage Δ
cosmos/x/evm/plugins/txpool/serializer.go 0.00% <0.00%> (ø)
cosmos/x/evm/types/tx.go 20.65% <0.00%> (-6.89%) ⬇️

@itsdevbear itsdevbear added the merge me daddy Trigger Beradozer to bulldoze the PR label Jul 28, 2023
Base automatically changed from testapp to main July 28, 2023 15:15
Signed-off-by: Devon Bear <itsdevbear@berachain.com>
@itsdevbear
Copy link
Member Author

@calbera g2g once github is good

@itsdevbear itsdevbear merged commit a32fc96 into main Jul 28, 2023
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge me daddy Trigger Beradozer to bulldoze the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants