Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

fix(precompile): fix edge case in precompile matching #926

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

shampoobera
Copy link
Contributor

No description provided.

@shampoobera shampoobera requested a review from calbera July 28, 2023 19:36
Copy link
Contributor

@calbera calbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #926 (57383a1) into main (693b533) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   59.60%   59.56%   -0.04%     
==========================================
  Files         105      105              
  Lines        4446     4442       -4     
==========================================
- Hits         2650     2646       -4     
  Misses       1682     1682              
  Partials      114      114              
Files Changed Coverage Δ
eth/core/precompile/factories.go 86.04% <100.00%> (+0.33%) ⬆️
eth/core/precompile/method_helpers.go 81.25% <100.00%> (-1.77%) ⬇️
eth/core/precompile/method_validation.go 91.17% <100.00%> (ø)

@shampoobera shampoobera merged commit 542dcfd into main Jul 28, 2023
14 checks passed
@shampoobera shampoobera deleted the shampoo/fix-pc-edgecase branch July 28, 2023 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants