fix(src/handler.ts): drop role with permissions

[ww-daniel-mora]

• Added logging to failed sql commands
• Allowed retry for concurrent delete
• Increased retry for concurrency error

[ww-daniel-mora]

example concurrent delete error

2024-06-12 17:52:38 UTC:10.255.6.210(19770):postgres@anonymizedData:[2425]:ERROR:  tuple concurrently deleted

[berenddeboer]

You have a hard-coded role here, which people may not have. Also from that discussion reassigning can lead to privilege escalation, so not keen on that approach. Can you remove this from the PR? I can merge most of it, but not this bit.

[ww-daniel-mora]

Will do.

[berenddeboer]

From that thread, I suggest you add something like this:

DO $$ 
DECLARE
    r RECORD;
BEGIN
    FOR r IN (SELECT schemaname FROM pg_schemas) LOOP
      EXECUTE 'REVOKE ALL PRIVILEGES ON ALL TABLES IN SCHEMA ' || quote_ident(r.schemaname) || ' FROM %s';
      EXECUTE 'REVOKE ALL PRIVILEGES ON ALL SEQUENCES IN SCHEMA ' || quote_ident(r.schemaname) || ' FROM %s';
      EXECUTE 'REVOKE ALL PRIVILEGES ON ALL FUNCTIONS IN SCHEMA ' || quote_ident(r.schemaname) || ' FROM %s';
      EXECUTE 'REVOKE ALL ON SCHEMA ' || quote_ident(r.schemaname) || ' FROM %I';
    END LOOP;
END $$;

Typing this from memory, and needs testing.

And you could add:

REVOKE CONNECT ON DATABASE db_name FROM role_name;

Keep the drop OWNED by %I as the first statement.

[berenddeboer]

But this all needs a bit of work, I prefer it if you move this to a separate PR.

[ww-daniel-mora]

Sequences specifically is what cause my failure but I can work that into a seperate PR

[ww-daniel-mora]

Ok for now I have reverted to the existing deletion behavior.

This change now

• Adds logging when retrying
• Expands retry filter to include concurrent delete
• Doubles the max retry count