Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql): enable rollback #24

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

ww-daniel-mora
Copy link
Contributor

  • Enable users to specify a rollback command for sql commands to be executed when the resource is deleted

Fixes #

* Enable users to specify a rollback command for sql commands to be executed when the resource is deleted
@ww-daniel-mora
Copy link
Contributor Author

Okay @berenddeboer I'd like to propose this as an alternative to more robust role deletion. This change adds an optional rollback to Sql constructs. My hope is this actually solves the role deletion issue by enabling users to undo permissions on their own explicitly when the Sql resource is deleted.

@berenddeboer berenddeboer merged commit b57c7a5 into berenddeboer:main Jun 14, 2024
4 checks passed
@berenddeboer
Copy link
Owner

Thank you so much, seems to be a nice new feature!

@ww-daniel-mora ww-daniel-mora deleted the feat/sql-rollback branch June 21, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants