feat: add support for RDS postgres instances #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelnk
force-pushed
the
feat/add-support-rds-postgres-instance
branch
from
94c2e76
to
be734a0
Compare
|
Thanks @emmanuelnk a lot of work went into this! But my first thought is that this should have been using a union. So there's really no need, unless you come from languages like Java, to introduce new classes. Why can't you change the provider "cluster" property to accept an RDS instance? Your change seems much more massive than needed, although I have not spent time to investigate this. |
emmanuelnk
force-pushed
the
feat/add-support-rds-postgres-instance
branch
from
be734a0
to
24d6e8c
Compare
|
@berenddeboer I took in your suggestion and made it such that |
|
OK, this is looking a lot more like what I expected to see! |
|
@berenddeboer Any chance we can get this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
IDatabaseInstanceas well.Also fixes #27