Refactor(Resub): Clear markA/B at the beginning #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrforcyber
changed the title
|
Thank you for figuring out the problem with "resub" on large cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on issue #324 , after adding a verbose log of node name and type, it turns out it reaches a PI when recursively collecting the node from root (Top-down).
After the reconvergence-driven cut process, the leaves should be able to bound the node in the recursive call, but failed in this large case. I checked and think there's possibility if the markB is not cleared at the first place, especially nodes should be added to leaves but skipped due to a markB with value not 0.
In the process of computing cut, markB is manually set to 1, so a clear process is proposed here before all nodes are being processed.