feat(plugin-recaptcha) Allow custom data to be sent #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugin: puppeteer-extra
bert-w
commented
Aug 28, 2022
| @@ -331,7 +334,7 @@ export class PuppeteerExtraPluginRecaptcha extends PuppeteerExtraPlugin { | |||
| prop.enterRecaptchaSolutions = async (solutions: types.CaptchaSolution[]) => | |||
| this.enterRecaptchaSolutions(prop, solutions) | |||
| // Add convenience methods that wraps all others | |||
| prop.solveRecaptchas = async () => this.solveRecaptchas(prop) | |||
| prop.solveRecaptchas = this.solveRecaptchas.bind(this, prop) | |||
There was a problem hiding this comment.
i dont know if this syntax works with async. bind() here makes sure that the first parameter is bound to the page object. Further calls to prop.solveRecaptchas should then call the solveRecaptchas with just 1 argument (the extraData) since the page has been bound thus disappeared
There was a problem hiding this comment.
tested this locally; works correctly (and properly assigns the function so that any additional arguments in the future will also work)
AndresGaibor
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improvement to previous additions that adds the
extraDataoption as a parameter. Note: I did not test this code since I dont currently have the typescript build env installed.This change should be backwards compatible (optional argument) and is a dirty fix to allow developers to send anything to the provider (there are some 2captcha API options that I could otherwise not send).