Replaces setup.py with pyproject.toml #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanhemsi
approved these changes
Jul 3, 2024
pyproject.toml
Outdated
Comment on lines
9
to
15
| name = "gptables" | ||
| authors = [ | ||
| {name = "ASAP", email = "ASAP@ons.gov.uk"} | ||
| ] | ||
| maintainers = [ | ||
| {name = "ASAP", email = "ASAP@ons.gov.uk"} | ||
| ] |
There was a problem hiding this comment.
Thank you for updating this in line with current policy
There was a problem hiding this comment.
Just a thought, should we expand the acronym in the name section?
| {name = "ASAP", email = "ASAP@ons.gov.uk"} | ||
| ] | ||
| dynamic = ["version"] | ||
| requires-python = '>=3.7' |
There was a problem hiding this comment.
I agree with this change. There may still be a small number of users on python 3.6 but they can use an earlier version of the package if they can't update their python version
setup.py
Outdated
There was a problem hiding this comment.
Are we able to do an editable install without the setup.py file?
There was a problem hiding this comment.
Answering my own question - this seems to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.