Fixes per review

betaflight · Nov 9, 2023 · e450977 · e450977
1 parent fa24cca
commit e450977
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/locales/en/messages.json b/locales/en/messages.json
@@ -1355,6 +1355,10 @@
         "message": "The pole count is the number of magnets on the bell of the motor. Do NOT count the stators where the windings are located. 5\" motors usually have 14 magnets, 3\" or smaller often have 12 magnets.",
         "description": "Help text for the Motor poles field of the ESC/Motor configuration"
     },
+    "configurationMotorIdleRpmHelp" : {
+        "message": "You will be able to edit Dynamic Idle setting on the PID tuning tab as this setting is profile dependant. When Dynamic Idle is set to zero static motor idle will apply",
+        "description": "Help text for dynamic idle setting" 
+    },
     "configurationThrottleMinimum": {
         "message": "Minimum Throttle (Lowest ESC value when armed)"
     },

diff --git a/src/js/tabs/motors.js b/src/js/tabs/motors.js
@@ -1164,13 +1164,10 @@ motors.initialize = async function (callback) {
             FC.PID_ADVANCED_CONFIG.motor_pwm_rate = parseInt($('input[name="unsyncedpwmfreq"]').val());
             FC.PID_ADVANCED_CONFIG.digitalIdlePercent = parseFloat($('input[name="digitalIdlePercent"]').val());
 
-            FC.ADVANCED_TUNING.idleMinRpm = parseInt($('input[name="idleMinRpm"]').val());
-
             await MSP.promise(MSPCodes.MSP_SET_FEATURE_CONFIG, mspHelper.crunch(MSPCodes.MSP_SET_FEATURE_CONFIG));
             await MSP.promise(MSPCodes.MSP_SET_MIXER_CONFIG, mspHelper.crunch(MSPCodes.MSP_SET_MIXER_CONFIG));
             await MSP.promise(MSPCodes.MSP_SET_MOTOR_CONFIG, mspHelper.crunch(MSPCodes.MSP_SET_MOTOR_CONFIG));
             await MSP.promise(MSPCodes.MSP_SET_MOTOR_3D_CONFIG, mspHelper.crunch(MSPCodes.MSP_SET_MOTOR_3D_CONFIG));
-            await MSP.promise(MSPCodes.MSP_SET_PID_ADVANCED, mspHelper.crunch(MSPCodes.MSP_SET_PID_ADVANCED));
             await MSP.promise(MSPCodes.MSP_SET_ADVANCED_CONFIG, mspHelper.crunch(MSPCodes.MSP_SET_ADVANCED_CONFIG));
             await MSP.promise(MSPCodes.MSP_SET_ARMING_CONFIG, mspHelper.crunch(MSPCodes.MSP_SET_ARMING_CONFIG));
 

diff --git a/src/tabs/motors.html b/src/tabs/motors.html
@@ -105,11 +105,11 @@
                                 <div class="number idleMinRpm">
                                     <label>
                                         <div class="numberspacer">
-                                            <input type="number" name="idleMinRpm" min="0" max="100" step="1"/>
+                                            <input type="number" name="idleMinRpm" min="0" max="100" step="1" readonly/>
                                         </div>
                                         <span i18n="pidTuningIdleMinRpm"></span>
                                     </label>
-                                    <div class="helpicon cf_tip" i18n_title="pidTuningIdleMinRpmHelp"></div>
+                                    <div class="helpicon cf_tip" i18n_title="configurationMotorIdleRpmHelp"></div>
                                 </div>
                                 <div class="number digitalIdlePercent">
                                     <label>