Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Failsafe Stage 1 options, improve explanation of function "Time in stage 1" #3565

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Translate Failsafe Stage 1 options, improve explanation of function "Time in stage 1" #3565

merged 5 commits into from
Sep 15, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Sep 4, 2023 •
edited
Loading

Translate Auto, Hold and Set for Stage 1

failsafeDelay and failsafeDelayHelp corrected to:
image

@github-actions

This comment has been minimized.

Sign in to view
@HThuren HThuren changed the title Translate Stage 1 options Translate Failsafe Stage 1 options Sep 4, 2023
@blckmn
Copy link
Member

blckmn commented Sep 5, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.10.0 milestone Sep 5, 2023
@github-actions

This comment has been minimized.

Sign in to view
@HThuren
Copy link
Member Author

HThuren commented Sep 6, 2023 •
edited
Loading

@ctzsnooze, by the way, rename this
image
to
Stage 1 - Channel Fallback Settings ?

@HThuren
Copy link
Member Author

HThuren commented Sep 10, 2023

@ctzsnooze, by the way, rename this image to Stage 1 - Channel Fallback Settings ?

@ctzsnooze, have you noticed this, if we on Failsafe do change "Channel Fallback Settings" to "Stage 1 - Channel Fallback Settings" ?

@HThuren
Update messages.json
27a9189 
change "Channel Fallback Settings" to "Stage 1 - Channel Fallback Settings"
@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren
Copy link
Member Author

HThuren commented Sep 10, 2023

@ctzsnooze @haslinghuis can you approve this PR ?

@HThuren HThuren changed the title Translate Failsafe Stage 1 options Translate Failsafe Stage 1 options, improve explanation of function "Time in stage 1" Sep 10, 2023
@haslinghuis haslinghuis merged commit 7c8ba06 into betaflight:master Sep 15, 2023
9 checks passed
@HThuren HThuren deleted the translateFailsafe branch September 15, 2023 21:24
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@HThuren @chmelevskij
Translate Failsafe Stage 1 options, improve explanation of function "…
a5df92f 
…Time in stage 1" (betaflight#3565)

* translate Stage 1 options

* small bug

* small bug

* Changed message and help text

* Update messages.json

change "Channel Fallback Settings" to "Stage 1 - Channel Fallback Settings"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze left review comments

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@HThuren HThuren

Labels
RN: TRANSLATION
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@HThuren @blckmn @haslinghuis @ctzsnooze @nerdCopter