Feature: Vite Build #3569
Feature: Vite Build #3569
Conversation
|
for anyone else reviewing. re-execution of @VitroidFPV , However |
This comment has been minimized.
This comment has been minimized.
It seems to be an issue with the copy plugin, I'm not sure why it's going wrong when it should just be copying some files. Will investigate |
|
thanks! |
|
@nerdCopter the plugin used copies the files for builds but serves them directly when used in dev. I picked a different one that will just copy them no questions asked in both envs. Try now! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
I will look into the LESS loading issues, but that may be for another PR |
|
same exact result. |
Did you re-install the packages again? Can confirm it working locally now on :8000 |
|
|
|
AUTOMERGE: (FAIL)
|
|
Works for me: git clean -xdf
yarn && yarn dev
|
|
Do you want to test this code? Here you have an automated build: |
|
Do you want to test this code? Here you have an automated build: |
| serveLocalesPlugin(), | ||
| copy({ | ||
| targets: [ | ||
| { src: ["locales", "resources", "src/tabs", "src/images"], dest: "src/dist" }, |
There was a problem hiding this comment.
Hmm, guessing we can't have /dist in the root because of root setting in vite config 🤔 Having it in src feels like will backfire
There was a problem hiding this comment.
interesting and good catch. but it is ignored by default (.gitignore )
There was a problem hiding this comment.
It was already set up that way in #3292. But yeah in src it will probably come back to bite us. What do you suggest?
There was a problem hiding this comment.
Should we look into
i don't really understand the errors. they do go away upon re-execution. they tend to only present themselves with new code/execution
yarn buildoutputs intosrc/dist/. Should be ready to be deployed