-
-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust plot colors #3580
Adjust plot colors #3580
Conversation
haslinghuis
commented
Sep 16, 2023
•
edited
Loading
edited
- Make colors more readable for light mode when out in the field in motors and sensors tab.
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
my eyes are 50+ years old and i find the dark lines harder to see on dark background. |
Background to this is that I was out in the field and trying to read the debug traces in bright sunlight, and I simply could not read the white-on-pale-green numbers. I regret to say that I'm a 'day theme' user with white background to the traces, and there a darker trace stands out nicely, and the text is easy to read. I accept that in night mode it is now a lot harder to read these traces: Looks like the pale colours work best in night mode, but the darker colours are better in day mode. The numbers are easier to read in both modes, and its the numbers I had most difficulty with. Maybe... two options:
Not sure what's best here. PS looking at those images, it's obvious that at some point it would be super nice if the debug listing showed the name of the debug field... that would be a lot of work though :-) |
This comment has been minimized.
This comment has been minimized.
agree. |
5dd7069
to
46c886e
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Do you want to test this code? Here you have an automated build: |
Looks great! Thank you @haslinghuis! Together with the Debug names showing up properly, the sensors tab is now much more useful! |
* Adjust plot colors * Fix dark-theme