Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajust gps aligment of Status and Quality #3581

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Ajust gps aligment of Status and Quality #3581

merged 2 commits into from
Sep 20, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Sep 16, 2023

New method to align Status and Quality, as wanted by @McGiverGim in #3566

Size fit to other languages than english.

image

@HThuren HThuren changed the title Ajust gp sheader Ajust gps aligment of Status and Quality Sep 16, 2023
@haslinghuis haslinghuis added this to the 10.10.0 milestone Sep 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Sep 16, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving based on screencap. not tested.

@haslinghuis haslinghuis merged commit cc32aaf into betaflight:master Sep 20, 2023
8 checks passed
@HThuren HThuren deleted the ajustGPSheader branch October 24, 2023 06:39
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@HThuren @chmelevskij
Ajust gps aligment of Status and Quality (betaflight#3581)
59ca12f 
* Step 1

* New aligment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@HThuren HThuren

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HThuren @blckmn @haslinghuis @nerdCopter