Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mode Tab have Modes grouped in category and selections depend on Cloud build options #3583

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Mode Tab have Modes grouped in category and selections depend on Cloud build options #3583

wants to merge 33 commits into from

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Sep 17, 2023 •
edited
Loading

This PR categorize Modes in groups to be controlled by Build Options or all modes if local build (ie. Build Option are empty).
Your selection are saved between sessions.

Categorys give more easy view of functionality when configure modes, ie. select Flightmode only to check setup in one list without need to schroll.

Categorys are Cloud build (fx USE_SERVO are not defined in firmware) or local build:
(SERVO are shown as example, will be hided in final design)
image

Examples of selections, where also unused mode still works:
image

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Sep 17, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@nerdCopter

This comment was marked as outdated.

Sign in to view
@HThuren
Copy link
Member Author

HThuren commented Sep 18, 2023

personally i don't see a need for this, but mine is just an opinion.

On the other side, it won't harm and help new users (like me :-)) to identify and understand flightmodes and give the overview for excatly them.

@nerdCopter

This comment was marked as outdated.

Sign in to view
@HThuren
Copy link
Member Author

HThuren commented Sep 18, 2023 •
edited
Loading

something wrong with "hide unused modes" -- expecting it to hide everything not set. https://youtu.be/mc_8-tA_eS4

I havn't tried with everything empty, will do
See it, good catch !

Benky
Benky reviewed Sep 20, 2023
View reviewed changes
src/js/tabs/auxiliary.js Outdated Show resolved Hide resolved
@sonarcloud

This comment was marked as outdated.

Sign in to view
@HThuren
Copy link
Member Author

HThuren commented Oct 10, 2023

... took long time to catch, just to discover start at index 1 solved the issue found by @nerdCopter

@github-actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@HThuren
Copy link
Member Author

HThuren commented Nov 10, 2023

Found any bugs here ?

@nerdCopter
Copy link
Member

Found any bugs here ?

yes :( https://youtu.be/yybuWCdXYfc

@HThuren
Copy link
Member Author

HThuren commented Nov 10, 2023

Damn :-(

@github-actions github-actions bot removed the Inactive label Nov 11, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
haslinghuis
haslinghuis previously requested changes Dec 11, 2023
View reviewed changes
src/js/tabs/auxiliary.js Outdated Show resolved Hide resolved
src/js/tabs/auxiliary.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis
Copy link
Member

Have no idea yet. But think we should decide on how it's going to look and work as I have already suggested using groups for certain modes we intent adding after release. But that's a bit hard now if they don't exist yet 😃

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@HThuren HThuren changed the title At Modes tab, now switch to hide non FlightModes Mode Tab have Modes grouped in category and selections depend on Cloud build options Dec 12, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@HThuren HThuren force-pushed the hideNonFlightmode branch from c205f78 to f42d174 Compare July 5, 2024 18:59
@netlify Netlify
Copy link

netlify bot commented Jul 5, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit db9e68c
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66884351b7f2da00087b1ba9
😎 Deploy Preview https://deploy-preview-3583.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benky Benky Benky left review comments

@atomgomba atomgomba atomgomba left review comments

@haslinghuis haslinghuis haslinghuis requested changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

Requested changes must be addressed to merge this pull request.

Assignees

@HThuren HThuren

Labels
Pinned RN: IMPROVEMENT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@HThuren @blckmn @nerdCopter @haslinghuis @atomgomba @Benky @chmelevskij @ctzsnooze