feat: only use rollup output for build #3597

chmelevskij · 2023-10-08T17:30:16Z

Current build setup copies files into folder and then runs full yarn installation.

Since we are building everything based on the usage we don't need all the node_modules and friends.

This changes reduces final package size after unpack on mac by ~100mb. Need to verify other platforms

Before

After

sonarqubecloud · 2023-10-08T17:31:54Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
31.7% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

blckmn · 2023-10-08T20:17:05Z

AUTOMERGE: (FAIL)

github identifies PR as mergeable -> FAIL
assigned to a milestone -> PASS
cooling off period lapsed -> PASS
commit count less or equal to three -> PASS
Don't merge label NOT found -> PASS
at least one RN: label found -> FAIL
Tested label found -> PASS
assigned to an approver -> PASS
approver count at least three -> FAIL

nerdCopter · 2023-10-09T13:36:45Z

"debug" version - Debian Linux 11

before/master:

$ du -h release/betaflight-configurator*
202M	release/betaflight-configurator-10.10.0_debug_d042471d-1.x86_64.rpm
136M	release/betaflight-configurator_10.10.0-debug-d042471d_amd64.deb
206M	release/betaflight-configurator_10.10.0-debug-d042471d_linux64-portable.zip

installed: 655M ./betaflight-configurator/

after/pr-3597:

$ du -h release/betaflight-configurator*
177M	release/betaflight-configurator-10.10.0_debug_55b0aaf9-1.x86_64.rpm
126M	release/betaflight-configurator_10.10.0-debug-55b0aaf9_amd64.deb
178M	release/betaflight-configurator_10.10.0-debug-55b0aaf9_linux64-portable.zip

installed: 539M ./betaflight-configurator/

oddly, all the *.js in the root installation folder, not the ./js/tabs/ (with exception of receiver_msp.js)

problems found:
flash-tab: load-online, no flash-button not enabled. same for local-local
nothing else found (shallow testing)

ctzsnooze · 2023-10-09T21:10:48Z

Thanks!

There is a small, long-term problem (not just from this PR) with the content of the Mac '.dmg' file.

If I download the Build for macOS, I get a file Betaflight-Configurator-macOS.zip (size 150.1Mb).

Double-click this -> betaflight-configurator_10.10.0-debug-daf3709_macOS.dmg (size 150.6Mb)

Double-click this -> disk image opens normally.

Is it possible to distribute the Mac version not as a zip of the dmg, but as the dmg itself? ie, at the stage of zipping the .dmg into a zip archive, omit that step for the Mac version?

Normally, Mac applications are distributed as dmg's only.

ctzsnooze · 2023-10-10T01:57:03Z

When testing this PR, using macOSX, all the javascript files for Tabs, ie all those from /js/tabs, except for receiver_msp.js and receiver_msp.map, have been moved to the root directory. Apart from the receiver_msp files, /js/tabs/ is empty.

The tabs still work properly.

nerdCopter · 2023-10-10T14:10:11Z

@ctzsnooze , did your flashing tab allow for flashing? mine did not in this PR.

nerdCopter · 2023-10-10T15:48:40Z

Old versions of Configurator retained the .js files inside the ./js/tabs/ folder. unsure when or why this changed. Would prefer such.

chmelevskij · 2023-10-12T14:37:20Z

Old versions of Configurator rtained the .js files inside the ./js/tabs/ folder. unsure when or why this changed. Would prefer such.

What is the value in that? We don't include the source for C code why should we do that for configurator?

I could adjust the rollup to keep that structure if we really do need it.

nerdCopter · 2023-10-12T15:21:56Z

so the packaged configurator does not run plain javascript? how does debug/inspect work? i see plaintext javascript in it.

chmelevskij · 2023-10-13T09:57:19Z

It does, but it's bundled based on usage (import/export) not just on the fact that we have things in node_modules

I will look into slightly different builds for prod and debug. I don't think you can even open dev tools in production builds.

We can see the original structure of the files etc. because of the sourcemaps (those .map files in final output). Chrome then re-assembles back the file structure in devtools. It has nothing to do with the original files being there.

haslinghuis · 2023-11-02T16:04:58Z

@chmelevskij please have a look - as Flash Firmware is not available after loading firmware.

chmelevskij · 2023-11-05T06:41:29Z

Hey there, will try to find time for this today 🙈

chmelevskij · 2023-12-10T17:29:44Z

@haslinghuis, had to copy in worker script we use in flasher tab https://github.com/betaflight/betaflight-configurator/blob/master/src/js/workers/hex_parser.js seemed to work now. Please verify

haslinghuis · 2023-12-10T17:33:14Z

git clean -xdf - so have to rebuild :)

haslinghuis · 2023-12-10T17:38:29Z

sonarqubecloud · 2023-12-17T09:14:41Z

Quality Gate failed

Failed conditions

15.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

github-actions · 2023-12-17T09:19:36Z

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

nerdCopter

approving, briefly tested both vite and nwjs

chore: reduce final package build output

This comment has been minimized.

Sign in to view

haslinghuis assigned chmelevskij Oct 8, 2023

haslinghuis added the Housekeeping label Oct 8, 2023

haslinghuis added this to the 10.10.0 milestone Oct 8, 2023

This comment has been minimized.

Sign in to view

haslinghuis removed this from the 10.10.0 milestone Dec 5, 2023

chmelevskij force-pushed the feat/reduce-build-output branch from 7761de5 to fa08d35 Compare December 10, 2023 17:02

This comment has been minimized.

Sign in to view

chore: reduce final package build output

5f4716e

chmelevskij force-pushed the feat/reduce-build-output branch from fbcd67d to 5f4716e Compare December 17, 2023 09:13

haslinghuis added the Tested label Dec 17, 2023

haslinghuis added this to the 10.10.0 milestone Dec 17, 2023

haslinghuis approved these changes Dec 17, 2023

View reviewed changes

nerdCopter approved these changes Dec 18, 2023

View reviewed changes

haslinghuis merged commit 8f85f08 into betaflight:master Dec 18, 2023
7 of 8 checks passed

chmelevskij added a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024

feat: only use rollup output for build (betaflight#3597)

9d66d39

chore: reduce final package build output

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: only use rollup output for build #3597

feat: only use rollup output for build #3597

chmelevskij commented Oct 8, 2023

sonarqubecloud bot commented Oct 8, 2023

This comment has been minimized.

blckmn commented Oct 8, 2023 •

edited

Loading

nerdCopter commented Oct 9, 2023 •

edited

Loading

ctzsnooze commented Oct 9, 2023 •

edited

Loading

ctzsnooze commented Oct 10, 2023 •

edited

Loading

nerdCopter commented Oct 10, 2023

nerdCopter commented Oct 10, 2023 •

edited

Loading

chmelevskij commented Oct 12, 2023

nerdCopter commented Oct 12, 2023

chmelevskij commented Oct 13, 2023

haslinghuis commented Nov 2, 2023

chmelevskij commented Nov 5, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

chmelevskij commented Dec 10, 2023

haslinghuis commented Dec 10, 2023

This comment has been minimized.

haslinghuis commented Dec 10, 2023 •

edited

Loading

sonarqubecloud bot commented Dec 17, 2023

github-actions bot commented Dec 17, 2023

nerdCopter left a comment

feat: only use rollup output for build #3597

feat: only use rollup output for build #3597

Conversation

chmelevskij commented Oct 8, 2023

Before

After

sonarqubecloud bot commented Oct 8, 2023

This comment has been minimized.

blckmn commented Oct 8, 2023 • edited Loading

nerdCopter commented Oct 9, 2023 • edited Loading

ctzsnooze commented Oct 9, 2023 • edited Loading

ctzsnooze commented Oct 10, 2023 • edited Loading

nerdCopter commented Oct 10, 2023

nerdCopter commented Oct 10, 2023 • edited Loading

chmelevskij commented Oct 12, 2023

nerdCopter commented Oct 12, 2023

chmelevskij commented Oct 13, 2023

haslinghuis commented Nov 2, 2023

chmelevskij commented Nov 5, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

chmelevskij commented Dec 10, 2023

haslinghuis commented Dec 10, 2023

This comment has been minimized.

haslinghuis commented Dec 10, 2023 • edited Loading

sonarqubecloud bot commented Dec 17, 2023

Quality Gate failed

github-actions bot commented Dec 17, 2023

nerdCopter left a comment

Choose a reason for hiding this comment

blckmn commented Oct 8, 2023 •

edited

Loading

nerdCopter commented Oct 9, 2023 •

edited

Loading

ctzsnooze commented Oct 9, 2023 •

edited

Loading

ctzsnooze commented Oct 10, 2023 •

edited

Loading

nerdCopter commented Oct 10, 2023 •

edited

Loading

haslinghuis commented Dec 10, 2023 •

edited

Loading