Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/improve dynamicIdle hidding #3624

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fix/improve dynamicIdle hidding #3624

merged 1 commit into from
Nov 2, 2023

Conversation

asizon
Copy link
Member

@asizon asizon commented Nov 2, 2023

There is an issue since we removed locale string for dynamic idle disabled, so i have hidde it for all versions since dynamicIdle exist in configurator(1.43).

@asizon asizon requested a review from haslinghuis November 2, 2023 16:25
@asizon asizon self-assigned this Nov 2, 2023
@asizon asizon changed the title Fix/inprove dynamicIdle hidding Fix/improve dynamicIdle hidding Nov 2, 2023
@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 2, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Nov 2, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@asizon
Copy link
Member Author

asizon commented Nov 2, 2023

I have improved idle min parametre phrase when it is disabled, thought that It is more appropriate and avoids OFF word repeating.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@asizon asizon force-pushed the dynamicIdle_hidding_fix branch from 9b60102 to 84d3fc8 Compare November 2, 2023 19:48
@asizon
Copy link
Member Author

asizon commented Nov 2, 2023

@haslinghuis sorry but we cant simplied it since it need diferent way to hide it, with your proposal Idle box will not appears after dshot bidir disabling because doesnt work with toggle way.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
haslinghuis
haslinghuis approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| 😉 👍

nerdCopter
nerdCopter approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested; assuming it gates correctly on older firmware if parameters do not exist

@asizon
Copy link
Member Author

asizon commented Nov 2, 2023

|| 😉 👍

wait please, i think finnaly we cant do it :(

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@asizon
Fix dynamicIdle hidding
2909781 
removed unused api version import

sinplify hidding, idlerpm disabled string improve

revert simplifing

simplifing digitalIdle hidding

 revert sinplifing
@asizon asizon force-pushed the dynamicIdle_hidding_fix branch from fba2ba1 to 2909781 Compare November 2, 2023 20:24
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@asizon
Copy link
Member Author

asizon commented Nov 2, 2023

@haslinghuis with || we cant go with other non digital esc protocols, digitalIdle is always here

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member

It would be nice to display (maybe even able to edit also) the idleMinRpm (will show active PID profile value) in motor tab when use_dshot_telemetry is enabled and idleMinRpm != 0

@asizon
Copy link
Member Author

asizon commented Nov 2, 2023 •
edited
Loading

It would be nice to display (maybe even able to edit also) the idleMinRpm (will show active PID profile value) in motor tab when use_dshot_telemetry is enabled and idleMinRpm != 0

Interesting..maybe we can discuss for another PR?

@haslinghuis haslinghuis merged commit f83c460 into betaflight:master Nov 2, 2023
8 of 9 checks passed
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@asizon @chmelevskij
Fix/improve dynamicIdle hidding (betaflight#3624)
40efcdc 
Fix dynamicIdle hidding

removed unused api version import

sinplify hidding, idlerpm disabled string improve

revert simplifing

simplifing digitalIdle hidding

 revert sinplifing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@asizon asizon

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@asizon @blckmn @haslinghuis @nerdCopter