Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button behaviour #3626

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix button behaviour #3626

merged 1 commit into from
Nov 7, 2023

Conversation

haslinghuis
Copy link
Member

Fixes buttons in firmware flasher as the backup process interrupted previous behavior.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 4, 2023
@haslinghuis haslinghuis self-assigned this Nov 4, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the disable-buttons branch 5 times, most recently from 63f9559 to af5b911 Compare November 4, 2023 03:58
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Nov 4, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@asizon
Copy link
Member

asizon commented Nov 5, 2023

How i can reproduce it @haslinghuis ? currently im making backup and it continues flashing process as expected

@haslinghuis
Copy link
Member Author

This PR disable buttons when applicable (more earlier) to prevent double clicks (debouncing the buttons),
Also turned into functions instead.

@asizon
Copy link
Member

asizon commented Nov 5, 2023 •
edited
Loading

Tested but now after backup, it starts flashing and some buttons remains enabled
image

@haslinghuis
Copy link
Member Author

haslinghuis commented Nov 5, 2023 •
edited
Loading

@asizon please test again - portpicker was enabling them again after cli reset.

@haslinghuis haslinghuis force-pushed the disable-buttons branch 4 times, most recently from 15e80ad to 8643083 Compare November 5, 2023 22:31
@haslinghuis haslinghuis changed the title Disable buttons Fix button behaviour Nov 5, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@betaflight betaflight deleted a comment from github-actions bot Nov 5, 2023
@betaflight betaflight deleted a comment from github-actions bot Nov 5, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

  • tested good; i only tested one FC, one flash w/ backup-clicked.

McGiverGim
McGiverGim approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but seems good.

@haslinghuis haslinghuis merged commit 90b7571 into betaflight:master Nov 7, 2023
9 checks passed
@haslinghuis haslinghuis deleted the disable-buttons branch November 7, 2023 13:01
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix button behaviour (betaflight#3626)
c6ace64 
Disable buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@asizon asizon asizon approved these changes

@McGiverGim McGiverGim McGiverGim approved these changes

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @asizon @nerdCopter @McGiverGim