Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macos build #3658

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Fix macos build #3658

merged 2 commits into from
Dec 9, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 6, 2023 •
edited
Loading

Fixes #3657 build

@haslinghuis haslinghuis self-assigned this Dec 6, 2023
@nerdCopter
Copy link
Member

if it works, may or may not be temporary.
on external project i'm moving to gulp-macdmg as it removes gulp-util and maybe macos-alias (unclear).
package.json's optionaldependencies not working alone, npm install --python=python2.7 not working alone. unfortunate requiring both to work, which is silly.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis
Copy link
Member Author

Removing 2nd commit

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Dec 7, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis requested a review from blckmn December 9, 2023 00:58
@blckmn blckmn merged commit ef4fec0 into betaflight:master Dec 9, 2023
9 checks passed
@haslinghuis haslinghuis deleted the fix-macos-build branch December 9, 2023 01:10
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix macos build (betaflight#3658)
5eef6f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@blckmn blckmn blckmn approved these changes

Assignees

@haslinghuis haslinghuis

Labels
Housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @nerdCopter @blckmn