Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide MAG and LEVEL PIDF values #3664

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Hide MAG and LEVEL PIDF values #3664

merged 3 commits into from
Dec 8, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 7, 2023 •
edited
Loading

No description provided.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 7, 2023
@haslinghuis haslinghuis self-assigned this Dec 7, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Dec 7, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ctzsnooze
Copy link
Member

This PR solves the issue by removing the weird 'Mag' line from Configurator. The Mag PID line, with its strange value of 40, that we see here:

Screen Shot 2023-12-08 at 09 51 23

Is now removed, and even if we enable Mag, we don't get that line anymore, just the Angle/Horizon stuff.

Screen Shot 2023-12-08 at 10 02 01

Problem solved.

Thanks, Mark.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Remove PIDS_ACTIVE Hide MAG and LEVEL PIDF values Dec 8, 2023
nerdCopter
nerdCopter approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving based on @ctzsnooze 's comment
  • is it fully backward compatible?

@haslinghuis
Copy link
Member Author

haslinghuis commented Dec 8, 2023 •
edited
Loading

We have removed backwards compatibility for firmware below API 1.41.0
We still carry over the PID settings for LEVEL and MAG so we might still need that in the future.

@haslinghuis haslinghuis merged commit 22bae0b into betaflight:master Dec 8, 2023
9 checks passed
@haslinghuis haslinghuis deleted the fix-pid-tuning branch December 8, 2023 13:57
@chmelevskij
Copy link
Member

What about

betaflight-configurator/src/tabs/pid_tuning.html

Line 387 in 710c6c0

<div id="pid_baro_mag_gps" class="pid_optional needed_by_ALT needed_by_VEL needed_by_MAG needed_by_Pos needed_by_PosR needed_by_NavR gui_box grey topspacer pid_tuning">
then? should we keep if if it's hidden or is that used by the other widget mentioned?

@haslinghuis
Copy link
Member Author

Yes this a quick fix and kept that code intentional as we may be needing it again after adding more sensor functionality but depends on firmware directions.

@chmelevskij
Copy link
Member

We can always revert it with git can't we 🙈

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Hide MAG and LEVEL PIDF values (betaflight#3664)
4be1f3e 
* Remove PIDS_ACTIVE

* Add todo

* Only remove optional elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @ctzsnooze @chmelevskij @nerdCopter