Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset button when loading a new firmware #3735

Closed
wants to merge 2 commits into from

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 6, 2024

No description provided.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 6, 2024
@haslinghuis haslinghuis self-assigned this Jan 6, 2024

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Jan 7, 2024

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

Copy link
Member

@blckmn blckmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer not to smash the healthcheck end point. It is not designed for configurator.

@haslinghuis haslinghuis closed this Jan 7, 2024
@haslinghuis haslinghuis deleted the add-health-info branch January 7, 2024 05:19
@haslinghuis haslinghuis restored the add-health-info branch January 7, 2024 18:01
@haslinghuis haslinghuis reopened this Jan 7, 2024
@haslinghuis haslinghuis changed the title Add health info for cloud build Reset button when loading a new firmware Jan 7, 2024
Copy link

sonarcloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 7, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

nerdCopter commented Jan 8, 2024

re: 6877e85d

no description provided but i do see the need.

it may need to be in another location as well.
to reproduce a problem on master and/or this PR:

  1. load local hex
  2. choose different flightcontroller in dialog (or auto-detect), flash button remains active which may be confusing or lead to bad flashing.

same does NOT happen for downloading cloud-builds. i.e. flash-button turned off appropriately.

@haslinghuis
Copy link
Member Author

Thanks for testing - will check local flash procedure.

@haslinghuis
Copy link
Member Author

Closing as this will be part of #3745

@haslinghuis haslinghuis deleted the add-health-info branch January 10, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

3 participants