Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mag declination css for dark mode #3737

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 7, 2024

Element did not work in dark mode. Also aligned it with other elements.

BEFORE:

image

AFTER:

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 7, 2024
@haslinghuis haslinghuis self-assigned this Jan 7, 2024
@haslinghuis haslinghuis force-pushed the fix-mag-declination-css branch from 4b22e58 to 21a2765 Compare January 7, 2024 17:32
Copy link

sonarcloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 7, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jan 7, 2024

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis changed the title Fix mag declination css Fix mag declination css for dark mode Jan 11, 2024
@chmelevskij
Copy link
Member

I love the size of these PRs ❤️ makes review. so much easier

@haslinghuis haslinghuis merged commit db460b8 into betaflight:master Jan 12, 2024
8 checks passed
@haslinghuis haslinghuis deleted the fix-mag-declination-css branch January 12, 2024 11:49
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Fix Mag declination in CSS for dark mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

4 participants