Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup more F3 code #3747

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Cleanup more F3 code #3747

merged 2 commits into from
Jan 30, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 11, 2024 •
edited
Loading

Cleaning up code used for F3 boards

@haslinghuis haslinghuis self-assigned this Jan 11, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Jan 11, 2024 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to still work, only one FC tested.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Remove boards.js Cleanup more F3 code Jan 12, 2024
@ctzsnooze
Copy link
Member

Isn't VCP still supported on F4 and F7 boards, and in the firmware?
I see quite a few F4 and F7 boards in the list of boards that is being deleted by this PR.

@haslinghuis
Copy link
Member Author

This table is no longer used. MSP_BOARD_INFO provides the info contained in firmware using targetCapabilities property.

See: #2355 (review)

@haslinghuis haslinghuis merged commit da3a732 into betaflight:master Jan 30, 2024
8 checks passed
@haslinghuis haslinghuis deleted the remove-boards branch January 30, 2024 01:18
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Cleanup more F3 code (betaflight#3747)
ae2738a 
* Remove boards.js

* Cleanup unused blocksize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

Assignees

@haslinghuis haslinghuis

Labels
Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @ctzsnooze @nerdCopter