Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code-server icon behind USE_CODE_SERVER_ICON #61

Merged
merged 2 commits into from
May 7, 2024

Conversation

krassowski
Copy link
Contributor

Closes #60

@xhochy
Copy link
Collaborator

xhochy commented May 6, 2024

Shouldn't we always use this icon?

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@xhochy xhochy merged commit 8e7165e into betatim:master May 7, 2024
2 checks passed
@benz0li
Copy link

benz0li commented May 7, 2024

@krassowski Your SVG does not work for me.

The jp-LauncherCard-icon is embedded as img and seems to prevent jp-icon0 from working.

@krassowski
Copy link
Contributor Author

This may be something we need to change on JupyterLab side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to switch the icon to code-server icon
3 participants