Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #1386, we changed from
IEnumerable
toICollection
then in #1634 the type was changed to
ICollection<T>
, this is great because now the Series.Values property is aware of the type of the collection, the problem as reported in #1673, is that some collections likeQueue<T>
andStack<T>
do not implementICollection<T>
This PR changes the type again to
IReadOnlyCollection<T>
, this interface seems to fit perfectly for the case of the library.