fix: rely on use-page-state to get the current value #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release to Master
…howing-PAGE-4710 fix(PAGE-4710): Remove unused zone from publish prod files.
Release Master
## [2.193.1](v2.193.0...v2.193.1) (2024-10-07) ### Bug Fixes * **PAGE-4710:** Remove unused zone from publish prod files. ([05e1bbf](05e1bbf))
…fault-value-PAGE-4719 Fix/datetime picker show default value page 4719
…orrectly-using-or-operator-PAGE-4078
…-behaving-correctly-using-or-operator-PAGE-4078 Fix/autocomplete filter not behaving correctly using or operator page 4078
## [2.193.1](v2.193.0...v2.193.1) (2024-10-10) ### Bug Fixes * add default value to current filter and show remaining records ([2a51f91](2a51f91)) * datepicker can interpret default meta-data data ([c56ecb3](c56ecb3)) * deepcopy optionFilter in autocomplete ([b777209](b777209)) * fixed filter in the autocomplete ([a6c71d3](a6c71d3)) * **PAGE-4710:** Remove unused zone from publish prod files. ([05e1bbf](05e1bbf)) * parse min- and maxDate correctly ([4baa79e](4baa79e)) * use empty string as fallback ([0a2d6a9](0a2d6a9))
…fault-value-PAGE-4719 Fix/datetime picker show default value page 4719
## [2.193.1](v2.193.0...v2.193.1) (2024-10-11) ### Bug Fixes * add default value to current filter and show remaining records ([2a51f91](2a51f91)) * datepicker can interpret default meta-data data ([c56ecb3](c56ecb3)) * deepcopy optionFilter in autocomplete ([b777209](b777209)) * fixed filter in the autocomplete ([a6c71d3](a6c71d3)) * force floatingLabel when a value is present in dataPicker ([d2997db](d2997db)) * give datePickerField a default value of null ([028183e](028183e)) * **PAGE-4710:** Remove unused zone from publish prod files. ([05e1bbf](05e1bbf)) * parse min- and maxDate correctly ([4baa79e](4baa79e)) * pipelines ([d72e9ec](d72e9ec)) * use empty string as fallback ([0a2d6a9](0a2d6a9))
It was used to check difference between two versions, and should not have been committed.
## [2.193.2](v2.193.1...v2.193.2) (2024-10-11) ### Bug Fixes * add default value to current filter and show remaining records ([2a51f91](2a51f91)) * datepicker can interpret default meta-data data ([c56ecb3](c56ecb3)) * deepcopy optionFilter in autocomplete ([b777209](b777209)) * fixed filter in the autocomplete ([a6c71d3](a6c71d3)) * force floatingLabel when a value is present in dataPicker ([d2997db](d2997db)) * give datePickerField a default value of null ([028183e](028183e)) * parse min- and maxDate correctly ([4baa79e](4baa79e)) * pipelines ([d72e9ec](d72e9ec)) * use empty string as fallback ([0a2d6a9](0a2d6a9))
Needed to merge the code to master
The reversed code solved a bug that only occured when the input-component was iterated. When a component is iterated, it would trigger some code in the compiler that didn't perfectly handle the state. But the solve broke a use-case, where component is in a conditional, and the state is persisted when the component is temporarily not on the page. By reverting this code, and fixing the compiler, all use-cases now work.
ingmar-stipriaan
previously approved these changes
Oct 21, 2024
ewoutquax
requested review from
jrquak and
ingmar-stipriaan
and removed request for
RobD-tech
ewoutquax
dismissed
ingmar-stipriaan’s stale review
The merge-base changed after approval.
|
🎉 This PR is included in version 2.195.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.195.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reversed code solved a bug that only occured when the input-component was iterated. When a component is iterated, it would trigger some code in the compiler that didn't perfectly handle the state.
But the solve broke a use-case, where component is in a conditional, and the state is persisted when the component is temporarily not on the page.
By reverting this code, and fixing the compiler, all use-cases now work.