fix: rely on use-page-state to get the current value #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reversed code solved a bug that only occured when the input-component was iterated. When a component is iterated, it would trigger some code in the compiler that didn't perfectly handle the state. But the solve broke a use-case, where component is in a conditional, and the state is persisted when the component is temporarily not on the page. By reverting this code, and fixing the compiler, all use-cases now work.
dylanBetty
approved these changes
Oct 28, 2024
dylanBetty
approved these changes
Oct 28, 2024
jeroenreijs
approved these changes
Oct 28, 2024
|
🎉 This PR is included in version 2.195.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.195.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reversed code solved a bug that only occured when the input-component was iterated. When a component is iterated, it would trigger some code in the compiler that didn't perfectly handle the state.
But the solve broke a use-case, where component is in a conditional, and the state is persisted when the component is temporarily not on the page.
By reverting this code, and fixing the compiler, all use-cases now work.