Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration guide #1366

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Jun 5, 2024

I re-ran the generate-release tool to create new stubs for the migration guide. Furthermore, I:

@BD103 BD103 requested a review from alice-i-cecile June 5, 2024 18:06
@BD103 BD103 added this to the Release v0.14 milestone Jun 5, 2024
@BD103
Copy link
Member Author

BD103 commented Jun 5, 2024

In order to get typos to pass, I had to exclude _guides.toml from checking. This means that all titles for migration guides will no longer be automatically checked. Is this ok?

@alice-i-cecile
Copy link
Member

Yeah that's fine IMO.

BD103 added 2 commits June 5, 2024 17:04
That PR did not have any breaking changes, as pointed out by Alice here: bevyengine#1366 (comment).
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels Jun 5, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 5, 2024
Merged via the queue into bevyengine:main with commit d24994e Jun 5, 2024
10 checks passed
@BD103 BD103 deleted the update-migration-guide branch June 5, 2024 23:03
@BD103 BD103 mentioned this pull request Jun 13, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Migration Guides C-Content S-Ready-For-Final-Review Ready for a maintainer to consider for merging X-Uncontroversial This work is generally agreed upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants