Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use less confusing terminology for string parts in DiagnosticPath #11438

Closed
alice-i-cecile opened this issue Jan 20, 2024 · 3 comments
Closed

Use less confusing terminology for string parts in DiagnosticPath #11438

alice-i-cecile opened this issue Jan 20, 2024 · 3 comments
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member 

          Nit: can we swap "components" here to "parts" to be less confusing in a Bevy context?

Originally posted by @alice-i-cecile in #9266 (comment)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Jan 20, 2024
@tharnival
Copy link
Contributor

I'll do it.

@tharnival tharnival mentioned this issue Jan 27, 2024
Closed
@mockersf
Copy link
Member

Components is the standard way to decompose a path.

We could rename DiagnosticPath to DiagnosticKey, then use another word like section?

Alternatively, we could revert #9266 and model bevy_diagnostics on a time series database as that's pretty much what it is and most of them have moved away from using paths

@alice-i-cecile
Copy link
Member Author

I don't think this is worth bikeshedding over. Going to close this and the linked PR as won't fix.

Working towards a time series model seems like a fine avenue to explore, but I don't have strong feelings there (as long as we can still support the use cases described in #9216).

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use less confusing terminology for string parts in DiagnosticPath tharnival/bevy
3 participants
@alice-i-cecile @tharnival @mockersf