Use less confusing terminology for string parts in DiagnosticPath
#11559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to text sections
matiqo15
approved these changes
Jan 27, 2024
matiqo15
added
C-Usability
|
components is very standard when speaking of parts of a path, section is a lot more confusing to me |
|
I find this meaningfully clearer, but I don't feel strongly here. Thank you @capt-glorypants for making this PR regardless :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11438
Changed confusing mentions of 'components' in
DiagnosticPaththat were referring to strings.Alice 'thumbs up'-ed JMS55's suggestion of using the term 'section', so I went with that instead of 'part' like mentioned in the issue.