Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example time api #10204

Merged
merged 15 commits into from
Oct 28, 2023
Merged

Example time api #10204

merged 15 commits into from
Oct 28, 2023

Conversation

SecretPocketCat
Copy link
Contributor

Objective

Solution

  • Add a new example that focuses on using Virtual time

Changelog

Added

  • new virtual_time example

Changed

  • moved time & timers examples to the new examples/time folder

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples A-Time Involves time keeping and reporting labels Oct 20, 2023
alice-i-cecile
alice-i-cecile approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice stuff: a clear interactive example with listed controls. Strongly in favor of the example reorganization too!

@SecretPocketCat
Copy link
Contributor Author

@rparrett Is there anything else you'd like to see changed? (Would be nice if this doesn't stay on main for 0.12, so the example is visible under the release tag 🙂 ).

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 28, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 28, 2023
Merged via the queue into bevyengine:main with commit 0824812 Oct 28, 2023
26 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@SecretPocketCat @ameknite
Example time api (bevyengine#10204)
a999407 
# Objective

- Fixes bevyengine#10133 

## Solution

- Add a new example that focuses on using `Virtual` time

## Changelog

### Added

- new `virtual_time` example

### Changed

- moved `time` & `timers` examples to the new `examples/time` folder
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@SecretPocketCat
Example time api (bevyengine#10204)
6c6c17d 
# Objective

- Fixes bevyengine#10133 

## Solution

- Add a new example that focuses on using `Virtual` time

## Changelog

### Added

- new `virtual_time` example

### Changed

- moved `time` & `timers` examples to the new `examples/time` folder
@mattlennon3
Copy link

@SecretPocketCat thankyou for this PR, it was exactly the guide I needed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@rparrett rparrett rparrett approved these changes

Assignees
No one assigned
Labels
A-Time Involves time keeping and reporting C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demonstrate how to use the Time API to effectively pause and resume your game
4 participants
@SecretPocketCat @mattlennon3 @rparrett @alice-i-cecile