Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Border and CornerRadius components to bevy_ui (Adopted) #11813

Closed
wants to merge 1 commit into from
Closed

Add Border and CornerRadius components to bevy_ui (Adopted) #11813

wants to merge 1 commit into from

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Feb 10, 2024

Objective

Solution

  • Rebase and solve change conflicts

@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets labels Feb 10, 2024
@tygyh tygyh force-pushed the ui-nodes-new-visual-features branch from f93938d to 1f5130f Compare February 11, 2024 17:23
@tygyh tygyh marked this pull request as ready for review February 11, 2024 17:23
@tygyh tygyh force-pushed the ui-nodes-new-visual-features branch from 1f5130f to 2c93385 Compare February 11, 2024 17:33
@tygyh tygyh closed this Feb 11, 2024
@tygyh tygyh deleted the ui-nodes-new-visual-features branch February 11, 2024 17:55
@tygyh tygyh restored the ui-nodes-new-visual-features branch February 11, 2024 17:55
@tygyh tygyh reopened this Feb 11, 2024
@hymm
Copy link
Contributor

hymm commented Feb 12, 2024

What's the difference between this pr and this one #8973?

@tygyh
Copy link
Contributor Author

tygyh commented Feb 12, 2024

What's the difference between this pr and this one #8973?

The other one's changes are probably a superset of this one and other changes.
If I had known about that PR I would not have made this.
One upside of this PR is it being almost ready to merge. I will look into the last few errors in the upcoming days.

@tygyh tygyh force-pushed the ui-nodes-new-visual-features branch from 2c93385 to 9045db9 Compare February 12, 2024 22:29
@tygyh tygyh mentioned this pull request Feb 13, 2024
Draft
@tygyh tygyh force-pushed the ui-nodes-new-visual-features branch from 9045db9 to a68b9ee Compare February 26, 2024 20:19
@tygyh
Copy link
Contributor Author

tygyh commented Feb 27, 2024

Since this PR is ready for review and #8973 is dormant I'd like to make partial progress by merging this

@tygyh tygyh force-pushed the ui-nodes-new-visual-features branch from a68b9ee to 2e7d084 Compare February 27, 2024 09:45
@alice-i-cecile
Copy link
Member

This PR doesn't seem to actually contain any code to render anything. I don't think this is in a mergeable state until a) it has rendering attached and b) the feature is demonstrated in an example.

@JMS55 JMS55 closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tygyh @hymm @alice-i-cecile @JMS55 @oceantume