Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't attempt to set cursor relative position for zero sized nodes #12395

Merged
merged 2 commits into from
Mar 10, 2024
Merged

don't attempt to set cursor relative position for zero sized nodes #12395

merged 2 commits into from
Mar 10, 2024

Conversation

robtfm
Copy link
Contributor

@robtfm robtfm commented Mar 9, 2024

Objective

fix #12007

Solution

when node size is zero on either axis, set RelativeCursorPosition::normalized to None.

@robtfm robtfm added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Mar 9, 2024
@james7132 james7132 added this to the 0.13.1 milestone Mar 10, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 10, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 10, 2024
Merged via the queue into bevyengine:main with commit bc4d8bb Mar 10, 2024
26 checks passed
mockersf pushed a commit that referenced this pull request Mar 10, 2024
@robtfm @mockersf
don't attempt to set cursor relative position for zero sized nodes (#…
3b97fd6 
…12395)

# Objective

fix #12007

## Solution

when node size is zero on either axis, set
`RelativeCursorPosition::normalized` to None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@ickshonpe ickshonpe Awaiting requested review from ickshonpe

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.

Interactivity regression in bevy_ui
3 participants
@robtfm @james7132 @alice-i-cecile