Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gizmos: Replace PositionItem with Vec3 #12401

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Gizmos: Replace PositionItem with Vec3 #12401

merged 1 commit into from
Mar 11, 2024

Conversation

james7132
Copy link
Member

Objective

Fix #12145.

Solution

Replace PositionItem with Vec3. Clean up the code.

@james7132 james7132 added C-Code-Quality A section of code that is hard to understand or change A-Gizmos Visual editor and debug gizmos labels Mar 10, 2024
@matiqo15 matiqo15 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 10, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 11, 2024
Merged via the queue into bevyengine:main with commit a089742 Mar 11, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsolage afonsolage afonsolage approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@matiqo15 matiqo15 matiqo15 approved these changes

@pablo-lua pablo-lua pablo-lua approved these changes

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace PositionItem in bevy_gizmos with a Vec3
6 participants
@james7132 @afonsolage @tim-blackbird @matiqo15 @pablo-lua @alice-i-cecile