Implement MutUntyped::from(mut_typed) #12406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkb0o
force-pushed
the
pr/mut_untyped_from_mut
branch
from
5677989
to
4c8b41f
Compare
james7132
approved these changes
Mar 10, 2024
james7132
added
C-Feature
|
Merging as trivial. |
|
Is there no risk of possible type safety loss by an automatically-applied |
|
Mut to MutUntyped is both safe and easy to do. The same reason why &mut T to PtrMut has a From implementation. MutUntyped to Mut is unsafe and requires proving the conversion is safe. From and Into are generally explicit about their application too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow to create MutUntyped<'a> instance from Mut<'a, T>.
Fixes #12405
Solution
Added impl<'a, T> From<Mut<'a, T>> for MutUntyped<'>