Split ScheduleGraph::process_configs function (adopted) #12435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just split it into several functions, because it is too large and hard to read. No functional changes.
Fix conflict (added `YesIgnoreDeferred` chained mode)
james7132
added
A-ECS
james7132
approved these changes
Mar 13, 2024
james7132
added
the
S-Ready-For-Final-Review
hymm
reviewed
Mar 13, 2024
alice-i-cecile
removed
the
S-Ready-For-Final-Review
|
Agreed on the comments. Pretty neutral on the change: I share @hymm's concerns about cross-function recursion, but the level of nesting and complexity was getting pretty hard to deal with. |
|
Alright, I understand your concerns. I've tried recombining recursion and simplifying a little bit, while still keeping some of the extracted functions. let me know if this is better in your opinions or if I should revert it back |
alice-i-cecile
approved these changes
Mar 13, 2024
hymm
approved these changes
Mar 16, 2024
| .graph | ||
| .add_edge(*previous_node, *current_node, ()); | ||
|
|
||
| if ignore_deferred { |
There was a problem hiding this comment.
Suggested change
| if ignore_deferred { | |
| if matches!(chained, Chain::YesIgnoreDeferred) { |
ignore_deferred variable seems to only be used here.
james7132
approved these changes
Mar 16, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adoption of #10617, resolved conflicts with main