stop retrying removed assets #12505
Merged
stop retrying removed assets #12505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robtfm
added
C-Bug
alice-i-cecile
approved these changes
Mar 16, 2024
IceSentry
approved these changes
Mar 16, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
@alice-i-cecile I'm not sure if 0.13.3 is still planned, but if so, this one would be an ideal candidate for cherry picking. Wanted to mention it since it'll save me some grief while I wait for 0.14.0 to stabilize. (sorry for the email to you both, just wanted to follow up on the thread from last night 🙂) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
assets that don't load before they get removed are retried forever, causing buffer churn and slowdown.
Solution
stop trying to prepare dead assets.