Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fixedbitset 0.5 #12512

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Conversation

james7132
Copy link
Member

@james7132 james7132 commented Mar 16, 2024

Objective

Improve code quality involving fixedbitset.

Solution

Update to fixedbitset 0.5. Use the new grow_and_insert function instead of grow and insert functions separately.

This should also speed up most of the set operations involving fixedbitset. They should be ~2x faster, but testing this against the stress tests seems to show little to no difference. The multithreaded executor doesn't seem to be all that much faster in many_cubes and many_foxes. These use cases are likely dominated by other operations or the bitsets aren't big enough to make them the bottleneck.

This introduces a duplicate dependency due to petgraph and wgpu, but the former may take some time to update.

Changelog

Removed: Access::grow

Migration Guide

Access::grow has been removed. It's no longer needed. Remove all references to it.

@james7132 james7132 added C-Dependencies A change to the crates that Bevy depends on C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Mar 16, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 17, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 17, 2024
Merged via the queue into bevyengine:main with commit 8327ce8 Mar 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change C-Dependencies A change to the crates that Bevy depends on M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants