Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a from Dir2 impl for Vec2 #12594

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add a from Dir2 impl for Vec2 #12594

merged 1 commit into from
Mar 20, 2024

Conversation

Brezak
Copy link
Contributor

@Brezak Brezak commented Mar 20, 2024 •
edited
Loading

Objective

Allow converting from Dir2 to Vec2 in generic code. Fixes #12529.

Solution

Added a From<Dir2> impl for Vec2.

alice-i-cecile
alice-i-cecile approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Math Fundamental domain-agnostic mathematical operations labels Mar 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 20, 2024
Merged via the queue into bevyengine:main with commit ed44eb3 Mar 20, 2024
30 checks passed
@Brezak Brezak deleted the vec2-from-dir2 branch April 24, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@NthTensor NthTensor NthTensor approved these changes

@atornity atornity atornity approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add impl From<Dir2> for Vec2
4 participants
@Brezak @alice-i-cecile @NthTensor @atornity